Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'subscribe' property to IResolverOptions #374

Merged
merged 3 commits into from
Aug 15, 2017

Conversation

blazarus
Copy link
Contributor

@blazarus blazarus commented Aug 3, 2017

This fixes issue #372. It seems like the 'subscribe' property was simply missing from the interface definition.

I've tested this by yarn linking the change against another project where I was running into the issue and verified I no longer hit the issue with this diff.
npm run test and npm run lint both pass locally.

This fixes issue ardatan#372. It seems like the 'subscribe' property was simply missing from the interface definition.
@apollo-cla
Copy link

@blazarus: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ItsEcholot
Copy link

Thanks a lot @blazarus for this fix. Could this be merged as fast as possible and included in the next release?

@stubailo stubailo merged commit ba1ab70 into ardatan:master Aug 15, 2017
@stubailo
Copy link
Contributor

Thanks!

@stubailo
Copy link
Contributor

Merged and published in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants