Fix alias problems by unaliasing queries we are sending to sub schemas

[freiksenet]

TODO:

• If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change

[pozylon]

@freiksenet @martijnwalraven

This query results in the correct response now:

{
  orders {
    itemTotal: total(category: TAXES) {
      amount
      currency
    }
  }
}

But as soon as you add a second alias with the same field, errors pop up, but only when using arguments.

This one runs perfect still:

{
  orders {
    itemTotal: total {
      amount
      currency
    }
    taxesTotal: total {
      amount
      currency
    }
  }
}

But that one here does not:

{
  orders {
    itemTotal: total(category: ITEMS) {
      amount
      currency
    }
    taxTotal: total(category: TAXES) {
      amount
      currency
    }
    paymentTotal: total(category: PAYMENT) {
      amount
      currency
    }
    deliveryTotal: total(category: DELIVERY) {
      amount
      currency
    }
    netTotal: total(category: NET) {
      amount
      currency
    }
  }
}

Response is:

{
  "data": null,
  "errors": [
    {
      "message": "Fields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.\nFields \"total\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "orders"
      ]
    }
  ]
}

And this is the result when firing the same query directly to the proxied server:

{
  "data": {
    "orders": [
      {
        "itemTotal": {
          "amount": 5958,
          "currency": "CHF"
        },
        "taxTotal": {
          "amount": 441,
          "currency": "CHF"
        },
        "paymentTotal": {
          "amount": 0,
          "currency": "CHF"
        },
        "deliveryTotal": {
          "amount": 0,
          "currency": "CHF"
        },
        "netTotal": {
          "amount": 5958,
          "currency": "CHF"
        }
      },...

Ugly workaround at the moment:

{
  order {
    total(category: TAXES) {
      amount
      currency
    }
  }
  taxes: order {
    total(category: ITEMS) {
      amount
      currency
    }
  }
}

[freiksenet]

Thanks! I suspected this will break. I'll check it out.