Handle errors better in merged schemas #425
Conversation
* Translate paths * Throw errors per field with errors from remote schema
freiksenet
force-pushed
the
stitching-handle-errors-better
branch
from
1221fdf to
1657ac0
Compare
| context, | ||
| info, | ||
| ) => { | ||
| const fieldName = info.fieldNodes[0].alias |
There was a problem hiding this comment.
Maybe call this responseKey to avoid confusion with info.fieldName?
src/stitching/errors.ts
Outdated
| import { GraphQLResolveInfo, responsePathAsArray } from 'graphql'; | ||
| import { locatedError } from 'graphql/error'; | ||
|
|
||
| const ERROR_SYMBOL = Symbol('Schema Merging Error'); |
There was a problem hiding this comment.
Maybe something like subSchemaErrors as the symbol name?
src/stitching/errors.ts
Outdated
| } | ||
| } | ||
| return { | ||
| childrenErrors, |
There was a problem hiding this comment.
I don't think I fully understand the logic, but is there ever a situation where you'd want to return both ownError and childrenErrors?
There was a problem hiding this comment.
No. I guess I should use algebraic type with key.
| const { ownError, childrenErrors } = getErrorsFromParent(parent, fieldName); | ||
| if (ownError) { | ||
| throw locatedError( | ||
| ownError.message, |
There was a problem hiding this comment.
This is not for now I think, but we may want to make sure we can also support additional error fields besides message.
There was a problem hiding this comment.
So the problem is the implementation of locatedError, it copies all the fields like "location" and "path" that we actually want to recreate.
|
@martijnwalraven All fixed. |
TODO: