Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvers parameter should be optional for mergeSchemas #462

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

kbrandwijk
Copy link
Contributor

@kbrandwijk kbrandwijk commented Nov 1, 2017

Per the documentation and runtime behavior. See #461

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

Per the documentation and runtime behavior.
@apollo-cla
Copy link

@kbrandwijk: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@kbrandwijk
Copy link
Contributor Author

There might be an added test that doesn't use any resolvers. As the tests are written in Typescript, that would immediately demonstrate that it's working. But the tests file for testMergeSchemas.ts is a bit hard to extend, because of the loops and the nesting.

@freiksenet freiksenet merged commit beb5d02 into ardatan:master Nov 2, 2017
@freiksenet
Copy link
Contributor

Thanks!

@kbrandwijk kbrandwijk deleted the patch-1 branch November 2, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants