Basic subscriptions support added to mergeSchemas and TypeRegistry.

[shipiak]

#420 - FourTwenty :)
Added support for subscription type (subscriptions will work with local schema only).

TODO:

• If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change

[apollo-cla]

@shipiak: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[freiksenet]

Looks good to me! Could you add the changelog entry, then I can merge.

[freiksenet]

I'm also not 100% sure about the test at this moment, it would be nice if you could add test that simulates actual subscription event and checks that both unmerged and merged schemas work.

[shipiak]

Yeah, you are right I was bit too quick with PR :)

Subscription resolvers are not working correctly on merged schema and cannot figure why.
delegatingResolver func is never called on subscription.

Still studying how delegating of resolvers work, but maybe it could be connected to subscription resolver having different structure?

It is not a function as in query or mutation but object with method subscribe:

Subscription: {
        commentAdded: {
          subscribe: () => pubsub.asyncIterator('commentAdded')
        }
    },

Would be happy for any pointers :)
Many thanks

[freiksenet]

Try adding delegating resolver to "subscribe" http://dev.apollodata.com/tools/graphql-subscriptions/subscriptions-to-schema.html

[freiksenet]

so here it would be

 fullResolvers.Subscription[name] = { subscribe: createDelegatingResolver(

[freiksenet]

I've added the comment where you should modify it. It might just work. :)

[shipiak]

Hi @freiksenet ,

Subscriptions in local schemas are now working correctly, however I would like to ask you to review change in defaultMergedResolver.ts. I had to add custom condition for mapping of subscription payload from asyncIterator. Result is in parent.data[responseKey] not parent[responseKey]

Many thanks.

[shipiak]

Hi guys,
@freiksenet @stubailo any feedback for this PR?
Could it be merged?

Many thanks!

[freiksenet]

Hi!

Thanks! I was on holiday for two weeks and then had flu, so I didn't have chance to review it. I'll do it today.

[freiksenet]

This looks awesome, thank you @shipiak.

[wawhal]

Any documentation related to this PR?