Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduping of new variable definitions when delegating to schemas #607

Merged
merged 4 commits into from
Feb 5, 2018
Merged

Deduping of new variable definitions when delegating to schemas #607

merged 4 commits into from
Feb 5, 2018

Conversation

adamkl
Copy link
Contributor

@adamkl adamkl commented Jan 31, 2018

This PR provided a fix for issue #602 where duplicate variables were being generated when delegating to a schema with multiple fragments referencing a linked field.

Added minor change to remove duplicates from the newVariableDefinitions created in delegateToSchema.ts. All exiting tests pass, and the new tests create do demonstrate the issue now pass as well.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@apollo-cla
Copy link

@adamkl: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link

@renatobenks-zz renatobenks-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants