Fix duplicate fragment bug for v3 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mfix22
commented
May 8, 2018
•
mfix22
commented
- Closes Duplicate fragment error on 3.0.0 #777
- If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
- Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.
- Closes #777
benjamn
suggested changes
May 8, 2018
src/transforms/FilterToSchema.ts
Outdated
| @@ -114,6 +114,7 @@ function filterDocumentToSchema( | |||
| }); | |||
| }); | |||
|
|
|||
| const fragmentSet = {}; | |||
There was a problem hiding this comment.
Let's make this = Object.create(null) so we don't inherit any truthy values from Object.prototype by accident.
benjamn
approved these changes
May 8, 2018
added 2 commits
May 8, 2018 10:21
Druotic
pushed a commit
to Druotic/graphql-tools
that referenced
this pull request
May 17, 2018
This was referenced May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.