-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract input extensions in extractExtensionDefinitions #948
Conversation
@jure: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I made this MR more minimal, so that it doesn't require Update: I think consensus for this feature was reached in #641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @jure - thanks very much!
Thanks @hwillson! 🎉 |
At the risk of sounding naggy, any chance of that prophesied 4.0.0 release? :) |
@jure Haha - not naggy at all! I've been meaning to post back here with an update; I ran into a world of hurt trying to get |
TODO:
This is a sort of exploratory thing, so apologies if it doesn't tick all of the boxes. The story is that
graphql
added input extensions in graphql/graphql-js#1373 (14.0.0) and I expected this to automatically work withgraphql-tools
. But it's actually missing a thing fromextractExtensionDefinitions
that would make it 'just work'. So I added that in this PR, but since it also requires updating tographql
14.0.0, some tests break.Not sure how to proceed, so I'd be super happy for some guidance, and happy to brings this through to the end.