Extract the new enum and union type extensions supported by graphql-js #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Similarly to #948, this makes
extractExtensionDefinitions
understand the newunion
andenum
type extensionsPlease note that this PR does not make the
enum
andunion
schema extensions "just work" withmakeExecutableSchema
and others, because these -- same as theinput
type extension added in #948 -- actually need graphql-js v14. But at least these definitions are not skipped and we get a good descriptive message what's wrong: