add the next multipart delimiter at the end of the chunk #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deferred responses come as multipart elements, send as individual HTTP response chunks. When a client receives one chunk, it should contain the next delimiter, so the client knows that the response can be processed, instead of waiting for the next chunk to see the delimiter. Side note: fixed the format of the last delimiter that was missing a trailing --
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
approved these changes
Aug 24, 2022
bnjjj
approved these changes
Aug 24, 2022
Comment on lines
+536
to
561
| // each chunk contains a response and the next delimiter, to let client parsers | ||
| // know that they can process the response right away | ||
| let mut first_buf = Vec::from( | ||
| &b"\r\n--graphql\r\ncontent-type: application/json\r\n\r\n"[..], | ||
| ); | ||
| serde_json::to_writer(&mut first_buf, &response).unwrap(); | ||
| first_buf.extend_from_slice(b"\r\n--graphql\r\n"); | ||
|
|
||
| let body = once(ready(Ok(Bytes::from(first_buf)))).chain( | ||
| stream.map(|res| { | ||
| let mut buf = Vec::from( | ||
| &b"content-type: application/json\r\n\r\n"[..], | ||
| ); | ||
| serde_json::to_writer(&mut buf, &res).unwrap(); | ||
|
|
||
| // the last chunk has a different end delimiter | ||
| if res.has_next.unwrap_or(false) { | ||
| buf.extend_from_slice(b"\r\n--graphql\r\n"); | ||
| } else { | ||
| buf.extend_from_slice(b"\r\n--graphql--\r\n"); | ||
| } | ||
|
|
||
| Ok::<_, BoxError>(buf.into()) | ||
| }), | ||
| ); | ||
|
|
There was a problem hiding this comment.
NIT: might be more readable in a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1588
deferred responses come as multipart elements, send as individual HTTP
response chunks. When a client receives one chunk, it should contain the
next delimiter, so the client knows that the response can be processed,
instead of waiting for the next chunk to see the delimiter.
Side note: fixed the format of the last delimiter that was missing a
trailing --