do not nullify the entire query if the root operation is not present #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the root operation was not returned by the subgraph (example: when there's an error), we should not nullify the entire data objet. Instead, it's the root operation field that should be null (unless it is not nullable)
This comment has been minimized.
This comment has been minimized.
martinbonnin
reviewed
Sep 1, 2022
martinbonnin
approved these changes
Sep 1, 2022
BrynCooke
approved these changes
Sep 1, 2022
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the root operation was not returned by the subgraph (example: when
there's an error), we should not nullify the entire data objet. Instead,
it's the root operation field that should be null (unless it is not
nullable)
Fixed #1670