Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of otel error handling #3218

Open
BrynCooke opened this issue Jun 6, 2023 · 2 comments
Open

Allow customization of otel error handling #3218

BrynCooke opened this issue Jun 6, 2023 · 2 comments
Labels
raised by user

Comments

@BrynCooke
Copy link
Contributor

Currently we follow otel http semantic conventions: https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/
There aren't many conventions for graphql yet, but we try to follow them and will match behavior as they are developed: https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/instrumentation/graphql/

Users have asked that there should at least be an option to mark otel status as failed if graphql errors are present in the response.
@BrynCooke BrynCooke mentioned this issue Jun 8, 2023
Open
28 tasks
@chandrikas
Copy link
Contributor

Will be done as part of #3226

@chandrikas chandrikas closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@BrynCooke BrynCooke reopened this Jan 17, 2024
@BrynCooke
Copy link
Contributor Author

Reopening as we still need to add this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
raised by user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrynCooke @chandrikas