Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for new API #419

Closed
Tracked by #303
BrynCooke opened this issue Feb 9, 2022 · 4 comments
Closed
Tracked by #303

Add examples for new API #419

BrynCooke opened this issue Feb 9, 2022 · 4 comments
Assignees

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Feb 9, 2022

Create an examples directory, include some basic stuff like a plugin and header manipulation.
Show code and YAML examples.

@o0Ignition0o

This comment was marked as outdated.

@abernix abernix removed the triage label Feb 23, 2022
@abernix abernix assigned garypen, bnjjj and BrynCooke and unassigned garypen and bnjjj Feb 23, 2022
@o0Ignition0o
Copy link
Contributor

  • Refactor current plugin examples so they call router::main() instead of building one
  • Create an example that does the current examples "main.rs" job.
  • add comments explaining that the "build your own router" / "compose your tower::Service" are not required if you only want to write a plugin

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Mar 15, 2022


Extension: if a subgraph returns something specific, change the http status code

Surrogate cache key from fastly ? -> combine em all and join em with commas

Inbound cookie changed from a cookie key / value pair to a header

Cookie : name "Jeremy" => value "foobarbaz" => make it a header "x-jeremy": "foobarbaz"

Go through our homebuilt plugins and document them better

Redacting email address / api keys from response errors```

@abernix
Copy link
Member

abernix commented Mar 15, 2022

Closing as these have been broken down into individual issues.

@abernix abernix closed this as completed Mar 15, 2022
@abernix abernix added this to the v0.1.0-alpha.9 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants