Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider query deduplication off by default and documenting its availability #717

Closed
abernix opened this issue Mar 22, 2022 · 2 comments
Closed
Assignees

Comments

@abernix
Copy link
Member

abernix commented Mar 22, 2022

Mostly to track a discussion that should happen.

We should at the very very least document that this behavior is on by default, but practically speaking this might be a very surprising change for those who are migrating from the Apollo Gateway. These sorts of requests do have other state-changing properties to them (like tracking for analystics, etc.).

That's not to say this isn't incredibly valuable, but I think it should be opt-in rather than opt-out and it could be a plugin.

@BrynCooke BrynCooke self-assigned this Mar 29, 2022
@BrynCooke
Copy link
Contributor

As we have discovered some issues with dedup this has been bumped up the priority list. #550

This is moving into a dedicated (experimental) plugin:

plugins:
  experimental.traffic_shaping: 
    all:
      dedup: true
    subgraphs: 
      products:
        dedup: false

@nateql
Copy link

nateql commented Mar 31, 2022

Was closed on the team board so I am closing it here.

@nateql nateql closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants