Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks git context author #338

Closed
jsegaran opened this issue Mar 12, 2021 · 0 comments · Fixed by #339
Closed

Checks git context author #338

jsegaran opened this issue Mar 12, 2021 · 0 comments · Fixed by #339
Labels
Milestone

Comments

@jsegaran
Copy link
Contributor

Description

Git contains an author and committer. The author is more semantically meaningful for what we are trying to show in studio.
We should send the git author instead of the committer to studio. Note the gql api is still called committer but we should rename it to author.

For github squash and merges the committer is set to no-reply@github.com instead of the email of the user which is stored in author so this makes post-merge attributions hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants