-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer script fails when tput
is unavailable
#371
Labels
Comments
abernix
changed the title
installer script fails because of absence of
installer script fails when Mar 26, 2021
tput
tput
is unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When running the installer in a more minimalistic shell/environment (e.g., Alpine), the installer fails because of an absence of the
tput
command. Thetput
command is leveraged to power ANSI colors in the installer output.Could we consider making
tput
an optional dependency of the installer script where — in its absence — the use of colored terminal output would degrade gracefully?The existing Spaceport installer guarded against the absence of this
tput
command: https://github.com/apollographql/spaceport/blob/44d8921e6e4d098fdc90dfbded7b959c60d8cb0a/public/install.sh#L1-L24Steps to reproduce
This requires Docker, but this should reproduce:
docker run --rm -t -i alpine:latest \ sh -c 'apk add curl && curl -sSL https://raw.githubusercontent.com/apollographql/rover/v0.0.4/installers/binstall/scripts/nix/install.sh | sh'
Expected result
Rover installation!
Actual result
Environment
RunCan't install!rover info
and paste the results hereOperating system and version: Alpine Linux
Shell (bash/zsh/powershell):
Version of Rover (
rover --help
): In theory, 0.0.4Installation method: curl
The text was updated successfully, but these errors were encountered: