Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when installing on an unsupported platform, add a guard+friendly message to the shell installer #393

Closed
abernix opened this issue Mar 30, 2021 · 0 comments · Fixed by #494
Closed

when installing on an unsupported platform, add a guard+friendly message to the shell installer #393

abernix opened this issue Mar 30, 2021 · 0 comments · Fixed by #494
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone
May 11 - GA

Comments

@abernix
Copy link
Member

abernix commented Mar 30, 2021 •
edited
Loading

Description

Related to #375, currently, when installing on Alpine, the installer errors out with sh: /tmp/{path}/rover: not found. If we could either enumerate supported architectures and refer users to open an issue when encountering one we don't support, or merely guard the invocation of the rover install command with a "catch" (and again reference to open an issue) in the event of failure, that would be friendly!
@abernix abernix added the feature 🎉 new commands, flags, functionality, and improved error messages label Mar 30, 2021
@lrlna lrlna added this to the April 27 milestone Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
May 11 - GA
Development

Successfully merging a pull request may close this issue.

feat(binstall): error on missing glibc apollographql/rover
3 participants
@abernix @lrlna @EverlastingBugstopper