Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover supergraph fetch #452

Closed
lrlna opened this issue Apr 16, 2021 · 3 comments · Fixed by #485
Closed

rover supergraph fetch #452

lrlna opened this issue Apr 16, 2021 · 3 comments · Fixed by #485
Assignees
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone

Comments

@lrlna
Copy link
Member

lrlna commented Apr 16, 2021

Description

It seems like Studio now has an API to do a supergraph fetch. We should consider replicating the same command in Rover to align with our graph and subgraph commands.

@lrlna lrlna added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Apr 16, 2021
@lrlna lrlna added this to the May 11 - GA milestone Apr 16, 2021
@lrlna lrlna removed the triage issues and PRs that need to be triaged label Apr 16, 2021
@EverlastingBugstopper EverlastingBugstopper self-assigned this Apr 28, 2021
@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Apr 28, 2021

The supergraphSdl field in the API is nullable, I'm guessing this is the case when composition errors occur. Do we want to return the latest composition error when attempting to fetch supergraph sdl? I'd.. assume we'd actually want this call to always return what's currently running on the gateway, and if the most recent composition publish has failed, maybe we should return the latest one to succeed?

@ndintenfass
Copy link
Contributor

I think not. Probably should be an error state that no supergraph schema was found (maybe that error could link to Studio? Or you think it should inline any errors??)

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Apr 28, 2021

IMO there should likely be a separate field we can query that isn't necessarily mostRecentCompositionPublish, but instead mostRecentSuccessfulCompositionPublish, which would always return the most recent valid composed supergraphSdl.

i'd imagine folks would want to use this to update the schema that their gateway is using, and it wouldn't be super great if that just.. broke every time composition breaks, given the frequency with which that occurs.

we figured it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants