Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspection does not handle gzip encoded response #608

Closed
keaeriksson opened this issue Jun 10, 2021 · 1 comment · Fixed by #620
Closed

Introspection does not handle gzip encoded response #608

keaeriksson opened this issue Jun 10, 2021 · 1 comment · Fixed by #620
Labels
Milestone

Comments

@keaeriksson
Copy link

keaeriksson commented Jun 10, 2021

Description

When running rover graph introspect towards a graph that gzip encodes the response body, the following error is produced:

error[E004]: error decoding response body: expected value at line 1 column 1

When disabling gzip, it works as expected.

Steps to reproduce

  • Run rover graph introspect towards a graph that has gzip enabled
  • Observe the error message

Expected result

Rover should gunzip the response if it returns a content-encoding: gzip header

Actual result

error[E004]: error decoding response body: expected value at line 1 column 1

Environment

Run rover info and paste the results here

Rover Info:
Version: 0.1.6
Install Location: /Users/xxx/Projects/xxx/xxx/node_modules/binary-install/bin/rover
OS: Mac OS 11.2.3 [64-bit]
Shell: /bin/zsh
@keaeriksson keaeriksson added bug 🐞 triage issues and PRs that need to be triaged labels Jun 10, 2021
@lrlna
Copy link
Member

lrlna commented Jun 15, 2021

hi @keaeriksson ! Thanks for this report. Definitely seems like something that should be fixed.

@lrlna lrlna removed the triage issues and PRs that need to be triaged label Jun 15, 2021
@lrlna lrlna added this to the June 22 milestone Jun 15, 2021
This was referenced Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants