Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celebrate the success of composition more, so it's no overshadowed by previous WARN #632

Closed
prasek opened this issue Jun 25, 2021 · 0 comments · Fixed by #685
Closed

Celebrate the success of composition more, so it's no overshadowed by previous WARN #632

prasek opened this issue Jun 25, 2021 · 0 comments · Fixed by #685
Labels

Comments

@prasek
Copy link

prasek commented Jun 25, 2021

Description

image

Steps to reproduce

  1. Clone https://github.com/apollographql/supergraph-demo
  2. Run make demo-managed:w

Expected result

We should celebrate the SUCCESS of composition in green text, to offset the red WARN that first-time users see when publishing a federated graphs.

Actual result

The success of composition is understated.

Environment

Rover Info:
Version: 0.1.6
Install Location: /Users/prasek/.cargo/bin/rover
OS: Mac OS 11.4.0 [64-bit]
Shell: /bin/zsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants