-
Notifications
You must be signed in to change notification settings - Fork 341
Provide a browser bundle suitable for direct browser consumption #47
Comments
@schrepfler if you could send a PR with a script that uses Webpack or Browserify to generate a bundle so that we can use |
I use |
I think this is the basis #48 but I need some validation as to 1) is the generated bundle consumable from a </script> tag and will the configuration publish the bundle onto npm or do I need to add more stuff to the package.json (I'm not really a JS dev so all this module mumbo jumbo seems a bit like black magic.) |
Although I think we merged the support for this, I can see https://unpkg.com/subscriptions-transport-ws@0.5.3 contains require statements (which I don't have locally.)
|
Actually, there seems to have been a regression, 0.5.2 was generating a different output: https://unpkg.com/subscriptions-transport-ws@0.5.2 |
Went through the changes for 0.5.3 and noticed the change in use of unpkg and that I need to explicitly use https://unpkg.com/subscriptions-transport-ws@0.5.3/browser/client.js |
Fixed in |
Noticed the client uses
require
which makes sense if one uses it on node or via browserify/build tools. What if we also expose a browser bundle for the client which already ships everything packaged so that it's possible to reference the library directly via https://unpkg.com?The text was updated successfully, but these errors were encountered: