Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to client instance #1038

Merged
merged 6 commits into from
Dec 14, 2016
Merged

Add version to client instance #1038

merged 6 commits into from
Dec 14, 2016

Conversation

stubailo
Copy link
Contributor

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@glasser
Copy link
Member

glasser commented Dec 14, 2016

It looks like you released this. Don't forget to merge.

@stubailo stubailo merged commit 42b5a4c into master Dec 14, 2016
@stubailo
Copy link
Contributor Author

Gosh, thanks.


cp README.md npm/
cp LICENSE npm/
cp .npmignore npm/

echo 'deploying to npm...'
cd npm && npm publish
cd npm && npm publish --tag test-version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you maybe forget to remove this after testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg I am literally the worst.

@helfer helfer deleted the add-version branch December 16, 2016 03:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants