-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change over to required gql
tag
#168
Conversation
gql
taggql
tag
I haven't tested that yet and it probably won't work? Still need to figure this one out |
It will work from this branch though since it's before your other changes! Definitely have used that before. |
Oh cool! If that is the case it should keep working. The deploy branch doesn't change how it works locally, only moves everything to root on publish |
Yeah I suppose the import paths will be different for |
Does the PR look good? |
|
||
assert.throws(() => { | ||
queryManager.query({ | ||
// Bamboozle TypeScript into letting us do this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the trowing tests should be written in JS to avoid this kind of type system coercion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh it's just one place right? I think it's great that typescript has a way of overriding types to allow us to test an edge case like this.
@stubailo really excited for this. It looks great to me! |
Going for it! |
install graphql for Meteor integration Right now, you also have to specify `apollo-server@^0.1.1`, but I think [that will change soon](apollographql/meteor-integration#26).
This will make it required to wrap all queries with:
See docs PR for details: https://github.com/apollostack/docs/pull/63
TODO:
gql
from a subdirectorynpm link
to test from an app