Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable normalization #214

Merged
merged 4 commits into from
May 13, 2016
Merged

Pluggable normalization #214

merged 4 commits into from
May 13, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented May 13, 2016

The goal is to allow people to pass their own ID getter functions to pick the key that is used for an object when it is put into the store. This addresses #204, but also makes #180 much easier.

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Testing strategy:

  • Check internal store of apollo client when option is passed to make sure it is used when writing to store; internal functions are already tested

@stubailo stubailo merged commit 029fcd7 into master May 13, 2016
@stubailo stubailo changed the title [WIP] Pluggable normalization Pluggable normalization May 13, 2016
@jbaxleyiii jbaxleyiii deleted the normalization branch May 17, 2016 02:04
jbaxleyiii pushed a commit that referenced this pull request Oct 17, 2017
Update to AC 0.5.0 for API docs
jbaxleyiii pushed a commit that referenced this pull request Oct 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant