Named fragment support. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helfer - could you review? |
Closed
| @@ -4,7 +4,7 @@ Expect active development and potentially significant breaking changes in the `0 | |||
|
|
|||
| ### vNEXT | |||
| - Removed AuthTokenHeaderMiddleware code and related tests from apollo-client [Issue #247](https://github.com/apollostack/apollo-client/issues/247) | |||
| - Fixed the getFromAST functions so that they work with queries that have named fragments (i.e. working toward named fragment support) | |||
There was a problem hiding this comment.
This needs an issue and PR link please!
|
Made the changes. |
| @@ -200,4 +202,22 @@ describe('AST utility functions', () => { | |||
| const newDoc = replaceOperationDefinition(queryWithFragments, newQueryDef); | |||
| assert.equal(print(newDoc), print(expectedNewQuery)); | |||
| }); | |||
|
|
|||
| it('should create the fragment sym table correctly', () => { | |||
There was a problem hiding this comment.
should be renamed to fragment map as well
|
Just one tiny comment about one of the tests. Ready to merge otherwise. 🎉 |
|
Fixed. |
|
Looks awesome! |
|
Hm, we seem to have merged something in the meantime. Can you rebase one last time? |
4 tasks
|
Rebased. |
|
Merged! |
ramusus
added a commit
to cinemanio/frontend
that referenced
this pull request
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named fragment support within the client. Now passes around the fragments within a query as a symbol table (i.e. an object mapping from fragment name to the fragment definition).
TODO: