Local fetch option in WatchQueryOptions #385
Conversation
| @@ -88,7 +96,7 @@ export function readSelectionSetFromStore({ | |||
| selectionSet, | |||
| rootId, | |||
| store, | |||
| throwOnMissingField: !returnPartialData, | |||
| throwOnMissingField: !returnPartialData && !noFetch, | |||
There was a problem hiding this comment.
Do we need to pass through noFetch everywhere just to do this? I feel like we could just set returnPartialData: true in QueryManager or something instead of adding a new option.
|
IMO we should never have a function or option that silently doesn't do the thing you want. It should either do something reasonable or throw an error. Since it's not clear how this option should interact with polling or refetch, I'd suggest those should just not be usable together with |
…eQuery so its functions are defined within itself given query options
| @@ -97,7 +97,7 @@ export class QueryScheduler { | |||
| throw new Error('Tried to register a non-polling query with the scheduler.'); | |||
| } | |||
|
|
|||
| const queryId = this.queryManager.generateQueryId(); | |||
| /* | |||
|
|
|||
| const subscriberFunction = (observer) => { | |||
There was a problem hiding this comment.
@Poincare when replacing QueryManager's "watchQuery" with scheduler's equivalent pass this subscriberFunction into ObservableQuery
There was a problem hiding this comment.
Ok cool. I think the scheduler will just register the polling query and use QueryManager to construct the ObservableQuery.
… method back to Observable superclass
| @@ -97,7 +97,7 @@ export class QueryScheduler { | |||
| throw new Error('Tried to register a non-polling query with the scheduler.'); | |||
| } | |||
|
|
|||
| const queryId = this.queryManager.generateQueryId(); | |||
| /* | |||
There was a problem hiding this comment.
Somehow I don't think this should be commented out? Should we delete the code?
|
This looks pretty good to me overall, just some issues with commented code and not sure the test is correct. Also, we should rebase this on master just in case. |
| @@ -8,6 +8,8 @@ Expect active development and potentially significant breaking changes in the `0 | |||
| - Stringify `storeObj` for error message in `diffFieldAgainstStore`. | |||
| - Fix map function returning `undefined` in `removeRefsFromStoreObj`. [PR #393](https://github.com/apollostack/apollo-client/pull/393) | |||
|
|
|||
| - Added a "noFetch" option to WatchQueryOptions that only returns available data from the local store (even it is incomplete). [Issue #225] https://github.com/apollostack/apollo-client/issues/225 and [PR #385] | |||
There was a problem hiding this comment.
This is not a valid markdown link :]
Fixes #225
TODO: