Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduling when the poll interval is the same, thanks @pfulop #568

Merged
merged 4 commits into from
Aug 19, 2016
Merged

Fix scheduling when the poll interval is the same, thanks @pfulop #568

merged 4 commits into from
Aug 19, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Aug 19, 2016 •
edited
Loading

Reopened #555 to add changelog and merge.

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

pfulop and others added 3 commits August 19, 2016 14:33
@pfulop
Update scheduler.ts
a815eda 
If there was already created timer for this interval and interval was then removed, the next polling interval won't start new timer.
wrote tests for restarting polling query
ff16113
Add changelog entry
cde3921
@stubailo stubailo changed the title Sashko 555 Fix scheduling when the poll interval is the same, thanks @pfulop Aug 19, 2016
@stubailo stubailo mentioned this pull request Aug 19, 2016
Closed
1 task
@stubailo stubailo merged commit aa21b02 into master Aug 19, 2016
@stubailo stubailo removed the ready label Aug 19, 2016
@jbaxleyiii jbaxleyiii mentioned this pull request Aug 23, 2016
Closed
@stubailo stubailo deleted the sashko-555 branch September 20, 2016 03:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stubailo @pfulop