deep assign if nested fragment #629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edvinerikson: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Also I have no idea how to fix the TS errors |
added 2 commits
September 9, 2016 20:17
edvinerikson
force-pushed
the
543-failing-test-case
branch
3 times, most recently
from
e9ca3fa to
195c1ed
Compare
edvinerikson
force-pushed
the
543-failing-test-case
branch
from
195c1ed to
cf69fdb
Compare
helfer
suggested changes
Sep 19, 2016
There was a problem hiding this comment.
@edvinerikson Thanks for the PR! There are just a couple of things to fix, and a rebase necessary before we can consider merging it.
| @@ -2,7 +2,7 @@ import isArray = require('lodash.isarray'); | |||
| import isNull = require('lodash.isnull'); | |||
| import isObject = require('lodash.isobject'); | |||
| import has = require('lodash.has'); | |||
| import assign = require('lodash.assign'); | |||
| const deepAssign = require('deep-assign'); | |||
| @@ -157,6 +157,84 @@ describe('reading from the store', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it.only('runs a nested fragment with multiple fragments', () => { | |||
There was a problem hiding this comment.
with it.only you're running just this single test!
| rootId: 'abcd', | ||
| }); | ||
|
|
||
| // The result of the query shouldn't contain __data_id fields |
|
Merging here: #669 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#534 fix attempt
I am not sure it fixes all cases for this. However some guidance would be helpful since I'm not familiar with the codebase