Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query diffing entirely #693

Merged
merged 6 commits into from
Sep 30, 2016
Merged

Remove query diffing entirely #693

merged 6 commits into from
Sep 30, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Sep 21, 2016

As discussed in #615

It does indeed simplify the code significantly!

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

@stubailo
Copy link
Contributor Author

Pretty confused about these test failures, I might be missing something big. Or perhaps there's a one line fix that gets them all.

@stubailo
Copy link
Contributor Author

@helfer can you review please?

@stubailo stubailo changed the title [WIP] Remove diffing Remove query diffing entirely Sep 30, 2016
@helfer
Copy link
Contributor

helfer commented Sep 30, 2016

Some changes seem unrelated to the PR (eg. concurrently and dataloader in package.json), but lgtm otherwise.

@helfer helfer merged commit a592b8a into master Sep 30, 2016
@stubailo stubailo deleted the remove-diffing branch October 15, 2016 22:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants