Fix 920 #922
Merged
Fix 920 #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cupools
commented
Nov 16, 2016
cupools
commented
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
- Update CHANGELOG.md with your change
added 2 commits
November 17, 2016 00:34
1. enable modify request headers by jiggling the order of arguments in BatchedNetworkInterface 2. update test case 3. add sortByKeys function in MockFetch, in order to avoid unexpected error of `No more mocked fetch responses` fix #920
|
@cupools: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
helfer
reviewed
Nov 16, 2016
| @@ -4,6 +4,9 @@ Expect active development and potentially significant breaking changes in the `0 | |||
|
|
|||
| ### vNEXT | |||
|
|
|||
| ### 0.5.5 | |||
There was a problem hiding this comment.
We usually just put the changelog entries under "vNEXT" until we make a release, because we don't know if the next one will be 0.5.5 or 0.6.0 until we release it.
There was a problem hiding this comment.
ok, I will make the change.
|
Thanks @cupools ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.