Manage TypeScript declaration files using npm #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
TypeScript 2 made it easier to install declaration files using npm.
Moving all the declaration file dependencies from typings to npm solves the problem where you have to install all the definitions manually (issue #124).
Now you just have to
npm install apollo-server
into your TS project and it just works, except for graphql definitions, those still need to be installed using the typings utility. Couldn't get them to work by installing from npm, for some reason.Note: Running
npm install
in an existing project will probably case duplicate definition errors with the typings directory. To resolve that just delete the typings directory and runtypings install
to install the graphql definitions.Also, having
@types/chai
in devDependencies resulted in missing type definition when compiling project that is depending on apollo-server. Thats why it's in dependencies section.