Run batching queries in parallel (#176) #273
Conversation
|
@helfer Please approve, i'll rebase & merge once the other PRs are merged.. |
| @@ -154,7 +154,9 @@ const version = 'modern'; | |||
| describe(`GraphQL-HTTP (apolloServer) tests for ${version} express`, () => { | |||
| describe('POST functionality', () => { | |||
|
|
|||
| it('allows gzipped POST bodies', async () => { | |||
| it('allows gzipped POST bodies', async function () { | |||
There was a problem hiding this comment.
How is this change related to this PR?
There was a problem hiding this comment.
Node 4 is much slower then Node 6.
I increase those 2 tests timeout since there is timeout after exhausting node abit..
…hreads as well, for Node v4
…gh for slow Node 4
| @@ -457,6 +469,29 @@ export default (createApp: CreateAppFunc, destroyApp?: DestroyAppFunc) => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('can handle batch requests in parallel', function() { | |||
There was a problem hiding this comment.
Another potential testing strategy that doesn't require the test to take a long time is to have much shorter timeouts in the queries but to expect the part of one query after a timeout to be able to observe the effect of another query.
There was a problem hiding this comment.
yeah i thought about creating a promise and resolve it on the other query.
but it felt just too bad..
this is probably what i would've done if it was not going through the whole query engine and such.
TODO:
Closes #176