Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed graphql-typings dependency from peer to standard #129

Merged
merged 2 commits into from
Sep 13, 2016
Merged

changed graphql-typings dependency from peer to standard #129

merged 2 commits into from
Sep 13, 2016

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Sep 8, 2016 •
edited
Loading

as discuessed in apollostack/meteor-starter-kit#30
@helfer, do we need to update CHANGLOG for that? i wouldn't..

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo
Copy link
Contributor

stubailo commented Sep 8, 2016

I think this merits a changelog entry because users are going to be aware of this change.

@helfer helfer merged commit 6476f8b into ardatan:master Sep 13, 2016
@DxCx DxCx deleted the peer-typings branch September 13, 2016 18:10
@helfer
Copy link
Contributor

helfer commented Sep 13, 2016

Merged, thanks!

@DxCx DxCx restored the peer-typings branch September 13, 2016 19:36
@DxCx DxCx deleted the peer-typings branch September 13, 2016 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DxCx @stubailo @helfer