Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scss Mixed Declarations Warnings #4647

Open
LeviticusMaximus opened this issue Jul 19, 2024 · 1 comment
Open

Scss Mixed Declarations Warnings #4647

LeviticusMaximus opened this issue Jul 19, 2024 · 1 comment
Labels

Comments

@LeviticusMaximus
Copy link

Loads of scss deprecation warnings in the console - making it pretty busy and harder to spot any other unrelated errors

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
92  │ ┌   .apos-theme--primary-blue {
93  │ │     @include apos-primary-mixin(#0062ff);
94  │ │   }
    │ └─── nested rule
... │
96  │     --a-base-1: #d1d3d5;
    │     ^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    apos-build/default/apos/modules/@apostrophecms/ui/scss/global/_theme.scss 96:3      @import
    apos-build/default/apos/modules/@apostrophecms/ui/scss/global/import-all.scss 11:9  root stylesheet

So I'm wondering if there's a fix to mute these warnings and/or if the Apostrophe team are planning to opt-in with the new behaviour and then release updated global scss files?

Thanks

@BoDonkey
Copy link
Contributor

Our next release will have a fix for this. In the meantime, I think the warnings won't display if you don't rebuild the admin UI, so only with APOS_DEV=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants