-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown node causing ThunderHub to crash when checking Forwards screen. #614
Comments
Same issue on my node, both on 0.13.30 and 0.13.31. |
I think I'm hitting the same bug. I'm seeing this in the devtools console just before being redirected to the login page:
|
Apply this diff to fix this bug: diff --git a/src/client/src/views/forwards/ForwardTable.tsx b/src/client/src/views/forwards/ForwardTable.tsx
index 64c25a34..e7897fc6 100644
--- a/src/client/src/views/forwards/ForwardTable.tsx
+++ b/src/client/src/views/forwards/ForwardTable.tsx
@@ -26,8 +26,8 @@ export const ForwardTable: FC<{ days: number }> = ({ days }) => {
cell: ({ row }: any) => (
<div style={{ whiteSpace: 'nowrap' }}>
{getNodeLink(
- row.original.channel_info.node2_info.public_key,
- row.original.channel_info.node2_info.alias
+ row.original.channel_info?.node2_info.public_key,
+ row.original.channel_info?.node2_info.alias
)}
</div>
),
diff --git a/src/client/src/views/home/reports/forwardReport/ForwardReportTables.tsx b/src/client/src/views/home/reports/forwardReport/ForwardReportTables.tsx
index 2bd9a0db..a250ebdd 100644
--- a/src/client/src/views/home/reports/forwardReport/ForwardReportTables.tsx
+++ b/src/client/src/views/home/reports/forwardReport/ForwardReportTables.tsx
@@ -87,8 +87,8 @@ export const ChannelTable: FC<ChannelTableProps> = ({ forwardArray }) => {
cell: ({ row }: any) => (
<div style={{ whiteSpace: 'nowrap' }}>
{getNodeLink(
- row.original.channel_info.node2_info.public_key,
- row.original.channel_info.node2_info.alias
+ row.original.channel_info?.node2_info.public_key,
+ row.original.channel_info?.node2_info.alias
)}
</div>
),
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem/bug
Someone opened and after a few minutes closed a channel to my node. The closing transaction is here: https://mempool.space/tx/5f3fdca0dca3d6afea5aaf70cf751ad0c3e17bb6283eb2bc88d8039c3e638e98
The closing transaction Peer is listed as Unknown.
Channel ID is 849168x3160x0
Peer ID is 03d5c6cb2ea6d8730c2a3334b106d38f56c6248fd270695122c00568a65856e967
Neither one is showing up on any Lightning explorers
If I go to the Home page of ThunderHub, the Routing report lists the node as "Node not found"
Issue is that now if I try to go to Forwards screen, ThunderHub just crashes to the login screen. It doesn't actually log me out, it just dumps to the login screen where I have to press the Connect button to get back to Home.
lncli forwarding history shows them as
Your environment
Expected behavior
I expect to go to Routes and see all the routed transactions same as I see them on the Home screen.
EDIT:
Since it has been over 24 hours, I can go into the Forwards screen now without it crashing, because these transactions don't show up in 1D view. If I switch the display to List and increase the time to 7D, all the transactions including these Unknown ones show up fine. If I keep it on 7D display and switch to Graph, it crashes to the login screen again. The issue seems to be with the graph unable to show them in that particular screen.
The text was updated successfully, but these errors were encountered: