-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-23527] iOS10: Support the UserNotifications framework #8078
Conversation
@hansemannn, It's good if we can create module for same. Because -
|
I would agree, but then we:
What I would suggest is that we create a Singleton NotificationManager class in the sdk that is clearly separated into both frameworks, but shares a common api endpoint. Let me still think about the module approach, but sooner or later, it will need to come to the SDK anyway. If it will be a customer wanting to have parity or the move to a higher minimum SDK version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TiAppiOSNotificationCategoryProxy.m, TiAppiOSNotificationActionProxy.m, TiAppiOSNotificationActionProxy.h files are deleted. Are these files getting used internally only? What if developer is using?
extends: Titanium.Module | ||
platforms: [iphone, ipad] | ||
osver: {ios: {min: "8.0"}} | ||
since: "7.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are targeting this PR for 7.3.0, can you please updated this and similar stuffs in doc to 7.3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
|
||
- (void)cancel:(id)args; | ||
- (void)cancel:(id)used; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 'unused' .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
iphone/Classes/TiAppiOSProxy.m
Outdated
; | ||
if ([TiUtils isIOS10OrGreater]) { | ||
DebugLog(@"[ERROR] Please use Ti.App.iOS.NotificationCenter.requestUserNotificationSettings in iOS 10 and later to request user notification settings asynchronously."); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this function is previously getting used, now it will not return relevant data in iOS >= 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
@hansemannn Can you resolve conflict please. Thanks! |
… TIMOB-23527 # Conflicts: # iphone/Classes/UtilsModule.m
JIRA: https://jira.appcelerator.org/browse/TIMOB-23527