Strike Select - doneRendering needs to check for v.value is present

[chewy2]

The doneRendering code needs to be moved to an afterRender in the renderer. The doneRender code only needs to be ran once, but its currently running infinite times and causing infinite loops under certain conditions.

[chewy2]

It appears we need to use the doneRendering event to handle the addition of options through a callback. In this case we need to also make sure that the doneRender checks to see if there is a v.value as well as a v.valueLabel otherwise when a component gets destroyed its stuck in an infinite loop due to not having a label, but theres no value to set a label.

[daneowens3]

expect this to be resolved in our next release, added the check for v.value.

[cnaccio]

@chewy2 I think I ran into this issue today with version 0.9.0 of the select component. I started receiving the error below in certain circumstances. Is this the same thing?

Here's the specific offending code/function in file strike_selectHelper; more specifically this line component.get('v.body').forEach(function(child) {

    getChildOptions: function(component, event, helper) {
        var options = [];

        component.get('v.body').forEach(function(child) {
            if ($A.util.isUndefined(child.select)) {

                var childOptions = helper.getChildOptions(child, event, helper);

                options = options.concat(childOptions);
            } else {
                options.push(child);
            }
        });

        return options;
    }

The function above is eventually called, but the top of the stack trace is this function in the same file:

getLabelByValue: function(component, event, helper) {
        helper.findChildOptionFromValue(component, event, helper);
}

Which calls this function

    findChildOptionFromValue: function(component, event, helper) {
        var options = helper.getChildOptions(component, event, helper);

        options.forEach(function(option, i) {
            if (option.get('v.value') === component.get('v.value')) {
                option.select();
                component.set('v.focusIndex', i);
                component.getEvent('onchange').fire();
            }
        });
    }

The line var options = helper.getChildOptions(component, event, helper); calls the first function I included above.

Any help, or insight would be much appreciated. Thanks in advance!