Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select all available app ids for the given bundle name #368

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: Select all available app ids for the given bundle name #368

merged 1 commit into from
Mar 22, 2024

Conversation

mykola-mokhnach
Copy link
Contributor 

dbug RemoteDebugger Current applications available:
dbug RemoteDebugger     Application: "PID:28725"
dbug RemoteDebugger         id: "PID:28725"
dbug RemoteDebugger         isProxy: false
dbug RemoteDebugger         name: "com.apple.WebKit.WebContent"
dbug RemoteDebugger         bundleId: "process-com.apple.WebKit.WebContent"
dbug RemoteDebugger         hostId: undefined
dbug RemoteDebugger         isActive: true
dbug RemoteDebugger         isAutomationEnabled: "Unknown"
dbug RemoteDebugger     Application: "PID:28685"
dbug RemoteDebugger         id: "PID:28685"
dbug RemoteDebugger         isProxy: false
dbug RemoteDebugger         name: "com.apple.WebKit.WebContent"
dbug RemoteDebugger         bundleId: "process-com.apple.WebKit.WebContent"
dbug RemoteDebugger         hostId: undefined
dbug RemoteDebugger         isActive: true
dbug RemoteDebugger         isAutomationEnabled: "Unknown"
dbug RemoteDebugger     Application: "PID:28677"
dbug RemoteDebugger         id: "PID:28677"
dbug RemoteDebugger         isProxy: false
dbug RemoteDebugger         name: "Safari"
dbug RemoteDebugger         bundleId: "com.apple.mobilesafari"
dbug RemoteDebugger         hostId: undefined
dbug RemoteDebugger         isActive: true
dbug RemoteDebugger         isAutomationEnabled: true
dbug RemoteDebugger     Application: "PID:28566"
dbug RemoteDebugger         id: "PID:28566"
dbug RemoteDebugger         isProxy: false
dbug RemoteDebugger         name: "amsengagementd"
dbug RemoteDebugger         bundleId: "com.apple.amsengagementd"
dbug RemoteDebugger         hostId: undefined
dbug RemoteDebugger         isActive: false
dbug RemoteDebugger         isAutomationEnabled: "Unknown"

As you could see in the above dict the process-com.apple.WebKit.WebContent bundle has two PIDs. The previous logic would only choose the first one

@mykola-mokhnach mykola-mokhnach merged commit c4f02b7 into appium:master Mar 22, 2024
7 checks passed
@mykola-mokhnach mykola-mokhnach deleted the localhost_load branch March 22, 2024 15:27
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
@semantic-release-bot
chore(release): 11.0.5 [skip ci]
02095f3 
## [11.0.5](v11.0.4...v11.0.5) (2024-03-22)

### Bug Fixes

* Select all available app ids for the given bundle name ([#368](#368)) ([c4f02b7](c4f02b7))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykola-mokhnach @KazuCocoa