Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Update Wiki page -How-to-start-an-AppiumDriver-locally #776

Closed
Dor-bl opened this issue Apr 13, 2024 · 9 comments
Closed

[Chore]: Update Wiki page -How-to-start-an-AppiumDriver-locally #776

Dor-bl opened this issue Apr 13, 2024 · 9 comments
Labels
Documentation good first issue First time contributers could start with that HelpWanted

Comments

@Dor-bl
Copy link
Collaborator

Dor-bl commented Apr 13, 2024

Description

The below Wiki page needs an update. (code is currently for version 4)
https://github.com/appium/dotnet-client/wiki/How-to-start-an-AppiumDriver-locally

@Dor-bl Dor-bl changed the title [Bug]: Update Wiki page -How-to-start-an-AppiumDriver-locally [Chore]: Update Wiki page -How-to-start-an-AppiumDriver-locally Apr 13, 2024
@Dor-bl Dor-bl added HelpWanted good first issue First time contributers could start with that labels Apr 13, 2024
@Dor-bl Dor-bl changed the title [Chore]: Update Wiki page -How-to-start-an-AppiumDriver-locally chore: Update Wiki page -How-to-start-an-AppiumDriver-locally Sep 14, 2024
@Dor-bl Dor-bl changed the title chore: Update Wiki page -How-to-start-an-AppiumDriver-locally [Chore]: Update Wiki page -How-to-start-an-AppiumDriver-locally Sep 14, 2024
@seriousQA
Copy link

@Dor-bl, hallo! I can help to update the Wiki page if you want. But I'm not a repo collaborator and you have to give me access for changing.

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 4, 2024

Hi @seriousQA first of all thank you for reaching out.
Secondly, I've temporarily removed the restrictions on the wiki.
Can you please update if you are able to change content inside of it?

@seriousQA
Copy link

@Dor-bl , thanks, now it works. I'll update the page..

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 4, 2024

@seriousQA Just a reminder, it needs to match the latest client version

@seriousQA
Copy link

seriousQA commented Nov 4, 2024

@Dor-bl, the page has been updated. You can review it. I recommend updating the title to "How to start and stop an Appium Service, Driver". If that's OK, I can change that and update the links to that page everywhere on the Wiki. Also, I can update other pages as well.

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 7, 2024

@seriousQA
Thanks a lot for your work. much appreciated.
some comments:

  1. The known issue section is empty. can be removed if no info can be added
  2. the https://github.com/appium/dotnet-client/wiki/How-to-start-an-AppiumDriver-locally#how-to-create-an-androiddriver-instance part seems outdated: See https://github.com/appium/dotnet-client/blob/v4/src/Appium.Net/Appium/Android/AndroidDriver.cs#L51
  3. Expand "Requirements" Section:
    Listing each requirement in bullet points rather than paragraphs may be helpful, like "Make sure node.js is in the PATH environment variable." This will improve scan-ability.

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 7, 2024

@seriousQA Regarding the title name, maybe Setting Up and Running an AppiumDriver Locally for Testing is a better choice.

@seriousQA
Copy link

@Dor-bl, thank you for review.

  1. "Known issue" section is removed;
  2. "AndroidDriver instance" section is updated;
  3. "Requirements" section is expanded;
  4. The title was changed; links to the wiki page are adjusted; actual title is "Setting Up and Running an AppiumDriver Locally for Testing".

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 9, 2024

@seriousQA awesome! Thanks again for the effort.
@KazuCocoa @jlipps, does the compensation plan include wiki updates as well?

@Dor-bl Dor-bl closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation good first issue First time contributers could start with that HelpWanted
Projects
None yet
Development

No branches or pull requests

2 participants