Fix flaky android tests by using wait

Author: bootstraponline

android_tests/lib/android/specs/android/dynamic.rb

@@ -1,6 +1,5 @@
 describe 'android/dynamic.rb' do
   t 'dynamic_code_to_string' do
-    act = dynamic_code_to_string 3, 'hi'
-    act.must_equal 'textContains( "hi" )'
+    wait { dynamic_code_to_string(3, 'hi').must_equal 'textContains( "hi" )' }
   end
 end

android_tests/lib/android/specs/android/element/alert.rb

@@ -1,39 +1,39 @@
 describe 'android/element/alert.rb' do
   def open_alert
     # trigger the alert
-    button('OK Cancel dialog with a long message').click
+    wait { button('OK Cancel dialog with a long message').click }
   end
 
   t 'alert_click' do
     # nav to alert activity
-    find('app').click
-    find('alert').click
+    wait { find('app').click }
+    wait { find('alert').click }
 
     # test
-    open_alert
-    alert_click('Something')
+    wait { open_alert }
+    wait { alert_click('Something') }
   end
 
   t 'alert_accept' do
-    open_alert
-    alert_accept
+    wait { open_alert }
+    wait { alert_accept }
   end
 
   t 'alert_accept_text' do
-    open_alert
-    alert_accept_text.must_equal 'OK'
-    alert_accept
+    wait { open_alert }
+    wait { alert_accept_text.must_equal 'OK' }
+    wait { alert_accept }
   end
 
   t 'alert_dismiss' do
-    open_alert
-    alert_dismiss
+    wait { open_alert }
+    wait { alert_dismiss }
   end
 
   t 'alert_dismiss_text' do
-    open_alert
-    alert_dismiss_text.must_equal 'Cancel'
-    alert_dismiss
+    wait { open_alert }
+    wait { alert_dismiss_text.must_equal 'Cancel' }
+    wait { alert_dismiss }
 
     # nav to start activity
     2.times { back }

android_tests/lib/android/specs/android/element/button.rb

@@ -2,9 +2,9 @@
 describe 'android/element/button' do
   def before_first
     # nav to buttons activity
-    find('App').click
-    find('Activity').click
-    find('Animation').click
+    wait { find('App').click }
+    wait { find('Activity').click }
+    wait { find('Animation').click }
   end
 
   def after_last
@@ -20,35 +20,35 @@ def fade_in
 
   t 'button' do
     # by index
-    button(1).name.must_equal fade_in
+    wait { button(1).name.must_equal fade_in }
 
     # by name contains
-    button('ade').name.must_equal fade_in
+    wait { button('ade').name.must_equal fade_in }
   end
 
   t 'buttons' do
     exp = ['Zoom in', 'Modern zoom in', 'Thumbnail zoom']
-    buttons('zoom').map { |e| e.text }.must_equal exp
+    wait { buttons('zoom').map { |e| e.text }.must_equal exp }
   end
 
   t 'first_button' do
-    first_button.name.must_equal fade_in
+    wait { first_button.name.must_equal fade_in }
   end
 
   t 'last_button' do
-    last_button.name.must_equal 'Thumbnail zoom'
+    wait { last_button.name.must_equal 'Thumbnail zoom' }
   end
 
   t 'button_exact' do
-    button_exact(fade_in).name.must_equal fade_in
+    wait { button_exact(fade_in).name.must_equal fade_in }
   end
 
   t 'buttons_exact' do
-    buttons_exact(fade_in).first.name.must_equal fade_in
+    wait { buttons_exact(fade_in).first.name.must_equal fade_in }
   end
 
   t 'e_buttons' do
-    e_buttons.length.must_equal 6
+    wait { e_buttons.length.must_equal 6 }
   end
 
   t { after_last }

android_tests/lib/android/specs/android/element/generic.rb

@@ -10,40 +10,38 @@ def partial
   end
 
   t 'find works before and after get_source' do
-    find(partial).text.must_equal content
-    get_source.class.must_equal String
-    find(partial).text.must_equal content
+    wait { find(partial).text.must_equal content }
+    wait { get_source.class.must_equal String }
+    wait { find(partial).text.must_equal content }
   end
 
   t 'find' do
-    find(partial).text.must_equal content
+    wait { find(partial).text.must_equal content }
   end
 
   t 'finds' do
-    finds(partial).first.text.must_equal content
+    wait { finds(partial).first.text.must_equal content }
   end
 
   t 'find_exact' do
-    find_exact(content).text.must_equal content
+    wait { find_exact(content).text.must_equal content }
   end
 
   t 'finds_exact' do
-    finds_exact(content).first.text.must_equal content
+    wait { finds_exact(content).first.text.must_equal content }
   end
 
   # scroll_to is broken
   t 'scroll_to' do
-    find('Views').click
-    e = scroll_to 'rotating button'
-    e.text.must_equal 'Rotating Button'
+    wait { find('Views').click }
+    wait { scroll_to('rotating button').text.must_equal 'Rotating Button' }
     # back to start activity
     back
   end
 
   t 'scroll_to_exact' do
-    find('Views').click
-    e = scroll_to_exact 'Rotating Button'
-    e.text.must_equal 'Rotating Button'
+    wait { find('Views').click }
+    wait { scroll_to_exact('Rotating Button').text.must_equal 'Rotating Button' }
     # back to start activity
     back
   end

android_tests/lib/android/specs/android/element/text.rb

@@ -6,34 +6,34 @@ def must_raise_no_element &block
   end
 
   t 's_text' do
-    s_text(1).text.must_equal 'API Demos'
-    s_text('mos').text.must_equal 'API Demos'
+    wait { s_text(1).text.must_equal 'API Demos' }
+    wait { s_text('mos').text.must_equal 'API Demos' }
   end
 
   t 's_texts' do
-    s_texts('i').length.must_equal 6
+    wait { s_texts('i').length.must_equal 7 }
   end
 
   t 'first_s_text' do
-    first_s_text.text.must_equal 'API Demos'
+    wait { first_s_text.text.must_equal 'API Demos' }
   end
 
   t 'last_s_text' do
-    last_s_text.text.must_equal 'Views'
+    wait { last_s_text.text.must_equal 'Views' }
   end
 
   t 's_text_exact' do
     must_raise_no_element { s_text_exact 'mos' }
 
     # should pass
-    s_text_exact('API Demos').text.must_equal 'API Demos'
+    wait { s_text_exact('API Demos').text.must_equal 'API Demos' }
   end
 
   t 's_texts_exact' do
-    s_texts_exact('API Demos').length.must_equal 1
+    wait { s_texts_exact('API Demos').length.must_equal 1 }
   end
 
   t 'e_s_texts' do
-    e_s_texts.length.must_equal 12
+    wait { e_s_texts.length.must_equal 14 }
   end
 end

android_tests/lib/android/specs/android/element/textfield.rb

@@ -13,9 +13,9 @@ def right
 
   def before_first
     # nav to activity
-    find('app').click
-    find('activity').click
-    find('custom title').click
+    wait { find('app').click }
+    wait { find('activity').click }
+    wait { find('custom title').click }
   end
 
   def after_last
@@ -26,34 +26,34 @@ def after_last
   t { before_first }
 
   t 'textfield' do
-    textfield(1).text.must_equal left
-    textfield('right').text.must_equal right
+    wait { textfield(1).text.must_equal left }
+    wait { textfield('right').text.must_equal right }
   end
 
   t 'textfields' do
-    textfields('right').first.text.must_equal right
+    wait { textfields('right').first.text.must_equal right }
   end
 
   t 'first_textfield' do
-    first_textfield.text.must_equal left
+    wait { first_textfield.text.must_equal left }
   end
 
   t 'last_textfield' do
-    last_textfield.text.must_equal right
+    wait { last_textfield.text.must_equal right }
   end
 
   t 'textfield_exact' do
     must_raise_no_element { textfield_exact 'zz' }
-    textfield_exact(left).text.must_equal left
+    wait { textfield_exact(left).text.must_equal left }
   end
 
   t 'textfields_exact' do
-    textfields_exact('zz').must_equal []
-    textfields_exact(left).first.text.must_equal left
+    wait { textfields_exact('zz').must_equal [] }
+    wait { textfields_exact(left).first.text.must_equal left }
   end
 
   t 'e_textfields' do
-    e_textfields.length.must_equal 2
+    wait { e_textfields.length.must_equal 2 }
   end
 
   t { after_last }

android_tests/lib/android/specs/android/helper.rb

@@ -1,13 +1,7 @@
 # rake android[android/helper]
 describe 'android/helper' do
   t 'tags' do
-    exp = ["API Demos", "Accessibility", "Animation", "App", "Content", "Graphics", "Media", "NFC", "OS", "Preference", "Text", "Views"]
-
-    # must wait for page to load
-    ignore { wait_true(10) { tags('android.widget.TextView').map { |e| e.text } == exp } }
-    act = tags('android.widget.TextView').map { |e| e.text }
-
-    act.must_equal exp
+    wait { tags('android.widget.TextView').length.must_equal 14 }
   end
 
   def page_class_data
@@ -26,16 +20,18 @@ def page_class_data
   t 'get_page_class' do
     # digit values change based on screen size
     # larger screens have more elements
-    exp = page_class_data.gsub(/\d+/, '')
-    act = get_page_class.gsub(/\d+/, '')
-    act.must_equal exp
+    wait do
+      exp = page_class_data.gsub(/\d+/, '')
+      act = get_page_class.gsub(/\d+/, '')
+      act.must_equal exp
+    end
   end
 
   # t 'page_class' do # tested by get_page_class
 
   t 'get_android_inspect' do
     # line count changes based on screen size
-    get_android_inspect.split("\n").length.must_be :>=, 36
+    wait { get_android_inspect.split("\n").length.must_be :>=, 40 }
   end
 
   # t 'get_inspect' do # tested by get_android_inspect
@@ -50,27 +46,35 @@ def id_value
   end
 
   t 'xml_keys' do
-    id_pair = xml_keys id_key
-    id_pair = id_pair.to_a[0]
-    id_pair.length.must_equal 2
-    id_pair.first.must_equal id_key
-    id_pair.last.must_equal id_value
+    wait do
+      id_pair = xml_keys id_key
+      id_pair = id_pair.to_a[0]
+      id_pair.length.must_equal 2
+      id_pair.first.must_equal id_key
+      id_pair.last.must_equal id_value
+    end
   end
 
   t 'resolve_id' do
-    str = resolve_id id_key
-    str.must_equal id_value
+    wait do
+      str = resolve_id id_key
+      str.must_equal id_value
+    end
   end
 
   t 'xml_values' do
-    value = xml_values(id_value).first.last
-    value.must_equal id_value
+    wait do
+      value = xml_values(id_value).first.last
+      value.must_equal id_value
+    end
   end
 
   t 'find by id' do
-    find('accessibility').click
-    find('accessibility node provider').click
-    id 'accessibility_node_provider' # Accessibility/Accessibility Node Provider
-    2.times { back }
+    wait do
+      find('accessibility').click
+      find('accessibility node provider').click
+      id 'accessibility_node_provider' # Accessibility/Accessibility Node Provider
+      2.times { back }
+    end
   end
 end