Skip to content

Commit e976552

Browse files
Add Android API 18 resource id to page output
Update webdriver
1 parent ddc5e36 commit e976552

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

appium_lib.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |s|
2424
s.homepage = 'https://github.com/appium/ruby_lib' # published as appium_lib
2525
s.require_paths = [ 'lib' ]
2626

27-
s.add_runtime_dependency 'selenium-webdriver', '~> 2.33.0'
27+
s.add_runtime_dependency 'selenium-webdriver', '~> 2.35.1'
2828
s.add_runtime_dependency 'awesome_print', '~> 1.1.0'
2929
s.add_runtime_dependency 'json', '~> 1.8.0'
3030
s.add_runtime_dependency 'toml', '~> 0.0.4'

lib/appium_lib/android/helper.rb

+15-5
Original file line numberDiff line numberDiff line change
@@ -325,13 +325,20 @@ def run node
325325
keys = node.keys
326326
return if keys.empty?
327327

328+
n_content = '@content-desc'
329+
n_text = '@text'
330+
n_class = '@class'
331+
n_resource = '@resource-id'
332+
n_node = 'node'
333+
328334
obj = {}
329-
obj.merge!( { desc: node['@content-desc'] } ) if keys.include?('@content-desc') && !node['@content-desc'].empty?
330-
obj.merge!( { text: node['@text'] } ) if keys.include?('@text') && !node['@text'].empty?
331-
obj.merge!( { class: node['@class'] } ) if keys.include?('@class') && !obj.empty?
335+
obj.merge!( { desc: node[n_content] } ) if keys.include?(n_content) && !node[n_content].empty?
336+
obj.merge!( { text: node[n_text] } ) if keys.include?(n_text) && !node[n_text].empty?
337+
obj.merge!( { class: node[n_class] } ) if keys.include?(n_class) && !obj.empty?
338+
obj.merge!( { resource_id: node[n_resource] } ) if keys.include?(n_resource) && !obj.empty?
332339

333340
r.push obj if !obj.empty?
334-
run_internal.call node['node'] if keys.include?('node')
341+
run_internal.call node[n_node] if keys.include?(n_node)
335342
end
336343

337344
run_internal.call node
@@ -345,9 +352,10 @@ def run node
345352

346353
out = ''
347354
results.each { |e|
348-
e_class = e[:class]
349355
e_desc = e[:desc]
350356
e_text = e[:text]
357+
e_class = e[:class]
358+
e_resource_id = e[:resource_id]
351359
out += e_class.split('.').last + "\n"
352360

353361
out += " class: #{e_class}\n"
@@ -358,6 +366,8 @@ def run node
358366
out += " name: #{e_desc}\n" unless e_desc.nil?
359367
end
360368

369+
out += " resource_id: #{e_resource_id}\n" unless e_resource_id.nil?
370+
361371
# there may be many ids with the same value.
362372
# output all exact matches.
363373
id_matches = @strings_xml.select do |kv|

lib/appium_lib/driver.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ def android_capabilities
360360
def ios_capabilities
361361
{
362362
platform: 'Mac 10.8',
363-
version: '6.0',
363+
version: '6.1',
364364
device: @device_cap || 'iPhone Simulator',
365365
name: @app_name || 'Ruby Console iOS Appium'
366366
}

0 commit comments

Comments
 (0)