error message when restarting job

[michaelrsweet]

Version: 1.1.20rc5
CUPS.org User: steve.p.walsh.hp

OS is Solaris 8

Got the following error message when restarting a print job even though the job restarted and printed:

lp -i testpr-3 -H restart
lp: set-job-attributes failed: client-error-not-possible

With debug2 I can see that the restarted job had completed before the set-job-attributes was processed.

CancelJob: id = 3
...
ProcessIPPRequest(.......
set_job_attrs:(......., ipp://localhost/jobs/3)
set_job_attrs: job #3 is finished and cannot be altered
send_ipp_error(......, 404)
....

The problem does not always occur. It depends how quick the job is processed. It is easier to see if print a small text file to a file device eg file:/tmp/prout

As the job does print it is not too much of a problem, just confusing for the user.

[michaelrsweet]

CUPS.org User: mike

Hmm, will look at the lp code and see what is going on...

[michaelrsweet]

CUPS.org User: mike

Super-simple patch attached - it was setting the attributes even though there was nothing to set... :)

[michaelrsweet]

CUPS.org User: mike

Fixed in CVS - the anonymous CVS repository will be updated at midnight EST.

[michaelrsweet]

"str362.patch":

Index: lp.c

RCS file: /development/cvs/cups/systemv/lp.c,v
retrieving revision 1.44
diff -u -r1.44 lp.c
--- lp.c 9 May 2003 18:50:42 -0000 1.44
+++ lp.c 7 Nov 2003 20:13:42 -0000
@@ -673,6 +673,9 @@
char uri[HTTP_MAX_URI]; /* URI for job */

• if (num_options == 0)
• return (0);

http = httpConnectEncrypt(cupsServer(), ippPort(), cupsEncryption());

language = cupsLangDefault();