Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stop installing banners/test page #4518

Closed
michaelrsweet opened this issue Nov 5, 2014 · 5 comments
Closed

Please stop installing banners/test page #4518

michaelrsweet opened this issue Nov 5, 2014 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 2.1-feature
CUPS.org User: wiz

The banner pages and test page as installed by cups-2.0.0 are not useful except on OS X. All other systems are using cups-filters, which ships with its own version of these files.

Till Kamppeter recommends not installing these files with cups any longer, see
https://bugs.linuxfoundation.org/show_bug.cgi?id=1236

A patch doing that is attached.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: wiz

Try attaching patch again.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

This can't happen until 2.1 at the earliest. And several functions in the web interface and elsewhere depend on these files being present, so I'd be interested to know what cups-filters is doing in place of these files.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: wiz

cups-filters installs slightly different copies of these files.
One such diff is visible in my cups-filters bug report at
https://bugs.linuxfoundation.org/show_bug.cgi?id=1222

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"data-Makefile.diff":

$NetBSD: patch-data_Makefile,v 1.1 2014/08/22 21:54:39 wiz Exp $

Do not install banner files and testprint to avoid conflict with
cups-filters, which installs them too.

https://bugs.linuxfoundation.org/show_bug.cgi?id=1222

--- data/Makefile.orig 2013-05-29 11:51:34.000000000 +0000
+++ data/Makefile
@@ -19,16 +19,9 @@ include ../Makedefs

Data files...

-BANNERS = \

  •   classified \
    
  •   confidential \
    
  •   secret \
    
  •   standard \
    
  •   topsecret \
    
  •   unclassified
    
    +BANNERS =

-DATAFILES = \

  •   testprint
    

    +DATAFILES =

    PPDCFILES =
    epson.h \

@michaelrsweet michaelrsweet added the enhancement New feature or request label Mar 17, 2016
@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant