Cups 2.0.1 build failed whith avahi disabled

[michaelrsweet]

Version: 2.0.1
CUPS.org User: psicotapa

Hi,

Bulding new Cups v2.0.1 fail when avahi is disabled with '--disable-avahi' or '--enable-avahi=no':

Making all in test...
Compiling ippserver.c...
Compiling ipptool.c...
ippserver.c:425:8: error: unknown type name 'AvahiThreadedPoll'
static AvahiThreadedPoll _DNSSDMaster = NULL;
^
ippserver.c:426:8: error: unknown type name 'AvahiClient'
static AvahiClient *DNSSDClient = NULL;
^
ippserver.c:5547:15: warning: unused variable 'ipp_txt' [-Wunused-variable]
ipp_txt_t ipp_txt; / Bonjour IPP TXT record /
^
1 warning and 2 errors generated.
../Makedefs:248: recipe for target 'ippserver.o' failed
make[1]: ** [ippserver.o] Error 1

The configure routine seems to be ok, as 'config.h' catch the disabled avahi (same for dnssd):

/*

• Do we have Avahi for DNS Service Discovery (aka Bonjour)?
  */

/* #undef HAVE_AVAHI */

The only solution is let the build go with avahi installed. Particularly I have no desire to keep avahi around just to use newest Cups.

Thanks for your time.

[michaelrsweet]

CUPS.org User: zk1234

I confirm the above. Additionally, the build fails if GNU TLS is not installed (even if the "disable-gnutls" configuration option is setup).
Sorry to say this, but I've never seen such a mess in any stable release of CUPS :-(

[michaelrsweet]

CUPS.org User: mike

I will see if I can setup some extra build bots to test more combinations of configure settings - as it stands now we have about 256 different combinations for Linux alone...

[michaelrsweet]

CUPS.org User: jsavikko

Didn't see this bug before posting new, but patch released in bug "STR #4529 compiling fails when configured with --disable-avahi and --disable-dnssd".

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"str4523.patch":

Index: test/ippserver.c

--- test/ippserver.c (revision 12268)
+++ test/ippserver.c (working copy)
@@ -419,12 +419,12 @@

• Globals...
  */

-# ifdef HAVE_DNSSD
+#ifdef HAVE_DNSSD
static DNSServiceRef DNSSDMaster = NULL;
-# else /* HAVE_AVAHI /
+#elif defined(HAVE_AVAHI)
static AvahiThreadedPoll *DNSSDMaster = NULL;
static AvahiClient *DNSSDClient = NULL;
-# endif / HAVE_DNSSD /
+#endif / HAVE_DNSSD */

static int KeepFiles = 0,
Verbosity = 0;