Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printer.tmpl "sides_supported" test is incorrect #4595

Closed
michaelrsweet opened this issue Mar 1, 2015 · 2 comments
Closed

printer.tmpl "sides_supported" test is incorrect #4595

michaelrsweet opened this issue Mar 1, 2015 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 2.0-current
CUPS.org User: pdewacht

The printer.tmpl template contains this fragment: "{sides_supported?, 2-sided printing:}", i.e. the web interface will display "2-sided printing" if the sides-supported property is set.

But since STR #3554, CUPS always sets the sides-supported property, even for printers that don't support duplex printing. So this test is no longer correct.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"str4595.patch":

Index: templates/es/printer.tmpl

--- templates/es/printer.tmpl (revision 12597)
+++ templates/es/printer.tmpl (working copy)
@@ -35,7 +35,7 @@

-
Descripción:{printer_info}
Ubicación:{printer_location}
Controlador:{printer_make_and_model} ({color_supported=1?color:escala de grises}{sides_supported?, dúplex:})
+
Controlador:{printer_make_and_model} ({color_supported=1?color:escala de grises}{sides_supported=one-sided?:, dúplex})
Conexión:{device_uri}
Opciones predeterminadas:job-sheets={job_sheets_default} media={media_default?{media_default}:desconocido}

Index: templates/ja/printer.tmpl

--- templates/ja/printer.tmpl (revision 12597)
+++ templates/ja/printer.tmpl (working copy)
@@ -35,7 +35,7 @@

-
説�:{printer_info}
場�:{printer_location}
����������:{printer_make_and_model} ({color_supported=1?���:��}{sides_supported?, 両��:})
+
����������:{printer_make_and_model} ({color_supported=1?���:��}{sides_supported=one-sided?:, 両��})
��:{device_uri}
�����設�:���={job_sheets_default} �����={media_default?{media_default}:��}

Index: templates/printer.tmpl

--- templates/printer.tmpl (revision 12597)
+++ templates/printer.tmpl (working copy)
@@ -35,7 +35,7 @@

-
Description:{printer_info}
Location:{printer_location}
Driver:{printer_make_and_model} ({color_supported=1?color:grayscale}{sides_supported?, 2-sided printing:})
+
Driver:{printer_make_and_model} ({color_supported=1?color:grayscale}{sides_supported=one-sided?:, 2-sided printing})
Connection:{device_uri}
Defaults:job-sheets={job_sheets_default} media={media_default?{media_default}:unknown}

Index: templates/ru/printer.tmpl

--- templates/ru/printer.tmpl (revision 12597)
+++ templates/ru/printer.tmpl (working copy)
@@ -35,7 +35,7 @@

-
�пи�ание:{printer_info}
Ра�положение:{printer_location}
��айве�:{printer_make_and_model} ({color_supported=1?�ве�ной:�е�но-бел�й}{sides_supported?, д�плек�на� пе�а��:})
+
��айве�:{printer_make_and_model} ({color_supported=1?�ве�ной:�е�но-бел�й}{sides_supported=one-sided?:, д�плек�на� пе�а��})
�одкл��ение:{device_uri}
�о �мол�ани�:job-sheets={job_sheets_default} media={media_default?{media_default}:unknown}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant