Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging to journal results in crash #4655

Closed
michaelrsweet opened this issue Jun 29, 2015 · 2 comments
Closed

logging to journal results in crash #4655

michaelrsweet opened this issue Jun 29, 2015 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

Version: 2.1b1
CUPS.org User: jpopelka

Using 2.1b1 with logging to journal results in crash. Patch attached.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"0001-Fix-crash-when-logging-via-journald.patch":

From 667091959e964bb6a1a7e4e8a6cc29b0dfd726b2 Mon Sep 17 00:00:00 2001
From: Jiri Popelka jpopelka@redhat.com
Date: Mon, 29 Jun 2015 16:27:40 +0200
Subject: [PATCH] Fix crash when logging via journald.

Signed-off-by: Jiri Popelka jpopelka@redhat.com

scheduler/log.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scheduler/log.c b/scheduler/log.c
index cd4e362..b7dff70 100644
--- a/scheduler/log.c
+++ b/scheduler/log.c
@@ -812,7 +812,9 @@ cupsdLogMessage(int level, /* I - Log level */
#elif defined(HAVE_SYSTEMD_SD_JOURNAL_H)
if (!strcmp(ErrorLog, "syslog"))
{

  • va_start(ap, message);
    sd_journal_printv(log_levels[level], message, ap);
  • va_end(ap);
    return (1);
    }
    #endif /* HAVE_ASL_H */
    --
    2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant