Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of CharSequences split #1216

Closed
tkountis opened this issue Nov 17, 2020 · 0 comments · Fixed by #1335
Closed

Improve performance of CharSequences split #1216

tkountis opened this issue Nov 17, 2020 · 0 comments · Fixed by #1335
Assignees
@tkountis
Labels
good first issue Good for newcomers

Comments

@tkountis
Copy link
Contributor

Improve split to return trimmed CharSequence values instead of doing a toString() conversion and an additional trim here that makes 2 copies of data when a space char is present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkountis tkountis

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CharSequences#split to support trim and min copies tkountis/servicetalk
2 participants
@tkountis @idelpivnitskiy