New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] license-header-check doesn't like Markdown files #434

Open

lorentey opened this issue Nov 18, 2024 · 1 comment

Labels

Member

lorentey commented Nov 18, 2024

The "soundness" check called license-header-check is choking on the file .github/ISSUE_TEMPLATE/BUG_REPORT.md.

▸ Run curl -s https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/check-license-header.sh | bash
** ERROR: Unsupported file extension md for file (exclude or update this script): .github/ISSUE_TEMPLATE/BUG_REPORT.md
bash: line 74: expected_file_header: unbound variable
Error: Process completed with exit code 1.

This check is therefore disabled. Once the issue above is fixed, we can consider enabling it.

The text was updated successfully, but these errors were encountered:

lorentey added bug enhancement and removed bug labels

Member

FranzBusch commented Nov 20, 2024 •

edited

Loading

You can use a .licenseignore file. We normally ignore all markdown files https://github.com/apple/swift-nio/blob/2a3a333d8b35a0decb8980497a604e51313c4b2a/.licenseignore#L12

So this is not an issue with the soundness workflow but something that you have to do in your repository here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment