Skip to content

[RFC] Restore using __SwiftValue in store on Linux #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift-ci merged 1 commit into from
Sep 10, 2020
Merged

[RFC] Restore using __SwiftValue in store on Linux #2500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions Sources/Foundation/Bridging.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,17 +187,12 @@ internal final class __SwiftValue : NSObject, NSCopying {
} else if let opt = value as? Unwrappable, opt.unwrap() == nil {
return NSNull()
} else {
#if canImport(ObjectiveC)
// On Darwin, this can be a native (ObjC) __SwiftValue.
let boxed = (value as AnyObject)
if !(boxed is NSObject) {
return __SwiftValue(value) // Do not emit native boxes — wrap them in Swift Foundation boxes instead.
} else {
return boxed as! NSObject
}
#else
return (value as AnyObject) as! NSObject
#endif
let boxed = (value as AnyObject)
if boxed is NSObject {
return boxed as! NSObject
} else {
return __SwiftValue(value) // Do not emit native boxes — wrap them in Swift Foundation boxes instead.
}
}
}

Expand Down