Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window updates can still cause BadStreamStateTransition #236

Closed
Lukasa opened this issue Sep 9, 2020 · 1 comment
Closed

Window updates can still cause BadStreamStateTransition #236

Lukasa opened this issue Sep 9, 2020 · 1 comment
Labels
kind/bug Feature doesn't work as expected.

Comments

@Lukasa
Copy link
Contributor

Lukasa commented Sep 9, 2020

We tried to fix this with #233, but a case was missed. If we receive a number of DATA frames in one channelRead cycle, one of which would trigger a window update frame but another, later one of which would set END_STREAM, we will incorrectly still emit window update frames because we won't spot that END_STREAM in time. We need to move that check.
@Lukasa Lukasa added the kind/bug Feature doesn't work as expected. label Sep 9, 2020
@Lukasa
Copy link
Contributor Author

Lukasa commented Sep 10, 2020

Fixed by #237.

@Lukasa Lukasa closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lukasa